fix(data-structures): ensure size consistency in RedBlackTree.from#6307
Merged
kt3k merged 1 commit intodenoland:mainfrom Dec 29, 2024
jiangshengdev:red-black-size
Merged
fix(data-structures): ensure size consistency in RedBlackTree.from#6307kt3k merged 1 commit intodenoland:mainfrom jiangshengdev:red-black-size
kt3k merged 1 commit intodenoland:mainfrom
jiangshengdev:red-black-size
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6307 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 547 547
Lines 41667 41671 +4
Branches 6314 6314
=======================================
+ Hits 40140 40145 +5
Misses 1484 1484
+ Partials 43 42 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when cloning an existing RedBlackTree using the static from method, the new tree’s #size field was not updated, leading to a mismatch between the reported size and the actual number of nodes. This commit addresses the issue by directly assigning the original tree’s #size to the new instance after copying all nodes.
Additional tests have been added to verify that size remains accurate and consistent following the cloning process.