-
Notifications
You must be signed in to change notification settings - Fork 662
feat(xml/unstable): add XML parsing and serialization module #6942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
could we get some benchmarks comparing to other parsers? |
Yes, that's a good idea. I'll look into it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6942 +/- ##
==========================================
+ Coverage 94.28% 94.49% +0.20%
==========================================
Files 584 593 +9
Lines 43186 44822 +1636
Branches 6933 7357 +424
==========================================
+ Hits 40720 42353 +1633
- Misses 2413 2417 +4
+ Partials 53 52 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updated the description now. Let me know if you would like to benchmark against a specific package |
7f792e6 to
e20f201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I have no idea why this formatting is happening 😅
|
Ref: denoland/deno#24995 |
New XML parsing and serialization module
What @std/xml has:
What @std/xml doesn't Have:
My use case is a 600MB file of product data in a Google Shopping/Merchant Center XML format. I use Sax for this, as it can stream.
Benchmark Results
I picked Sax (for streaming) and fast-xml-parser (for non-streaming) as the reference cases. These seem like the most widely used packages, but please leave a comment if you would like to see a comparison to another package.
I ran these benchmarks a few hundred times (except the big streaming test that I ran about 15-20 times). All on a MacBook M1 Max. The test files are located in
testdata(not the 600MB one naturally)Small Files (<10KB)
Large Files (large.xml - 300KB)
Streaming (597MB file)