Skip to content

perf(cache): optimize _serializeArgList key generation#7044

Open
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
tomas-zijdemans:cache-internal
Open

perf(cache): optimize _serializeArgList key generation#7044
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
tomas-zijdemans:cache-internal

Conversation

@tomas-zijdemans
Copy link
Contributor

@tomas-zijdemans tomas-zijdemans commented Mar 13, 2026

Reduce overhead in _serializeArgList.ts by replacing the assertWeakKey helper with a direct WeakRef check, using a Set instead of an array for key tracking, and cutting redundant map lookups.

Improved the test coverage.

@tomas-zijdemans tomas-zijdemans requested a review from kt3k as a code owner March 13, 2026 09:06
@github-actions github-actions bot added the cache label Mar 13, 2026
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.02%. Comparing base (6df7f21) to head (f680890).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7044   +/-   ##
=======================================
  Coverage   94.01%   94.02%           
=======================================
  Files         627      627           
  Lines       50029    50028    -1     
  Branches     8807     8807           
=======================================
+ Hits        47037    47039    +2     
+ Misses       2413     2411    -2     
+ Partials      579      578    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant