feat(cache): expose cache property on memoized functions#7045
Open
tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Open
feat(cache): expose cache property on memoized functions#7045tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7045 +/- ##
==========================================
- Coverage 94.01% 94.01% -0.01%
==========================================
Files 627 627
Lines 50029 50030 +1
Branches 8807 8807
==========================================
Hits 47037 47037
Misses 2413 2413
- Partials 579 580 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed the cache as a public property so callers can inspect or manually invalidate the cache (e.g.
fn.cache.delete(...),fn.cache.clear()).Changed MemoizationCache from type alias to interface to align with the style guide
Removed unused import and dropped the lint suppression.
Replaced the
cache.has(key)+cache.get(key)!two-step lookup with a singlecache.get(key)call. This avoids a redundant lookup on every cache hit.Simplified tests a lot, maintaining coverage