ale: add FindNearestFileOrDirectory function#5033
ale: add FindNearestFileOrDirectory function#5033w0rp merged 2 commits intodense-analysis:masterfrom
FindNearestFileOrDirectory function#5033Conversation
|
If this API is suitable, I'll add commits to migrate |
mathstuf
force-pushed
the
find-nearest-file-or-dir
branch
from
23c59e0 to
6b1cbc5
Compare
It matches the API name better and now lives beside the test file for `FindNearestDirectory`.
mathstuf
force-pushed
the
find-nearest-file-or-dir
branch
4 times, most recently
from
d144ada to
6ad4b81
Compare
Some anchor paths can be files or directories (e.g., `.git` is a directory normally, but a file for worktrees). Add a function that finds either type of path and returns the nearest.
mathstuf
force-pushed
the
find-nearest-file-or-dir
branch
from
6ad4b81 to
d662844
Compare
w0rp
left a comment
w0rp
left a comment
There was a problem hiding this comment.
This makes sense to me and I see the need for it. Cheers! 🍻
Apologies for the delay looking at this. Looks good to me, and apparently to w0rp too. I ran grep and navigated the sources a bit, pushed #5038 and created #5039. Would you still be up for going through the list of tools and adapt them to use your new function? I might have a go at a few more of the tools I'm actively using. Somewhat related, I also filed #5040 which is more of an idea than something I'm sure anyone (me included) is fully committed to. |
* test: rename `FindNearestFile` test file It matches the API name better and now lives beside the test file for `FindNearestDirectory`. * ale: add `FindNearestFileOrDirectory` function Some anchor paths can be files or directories (e.g., `.git` is a directory normally, but a file for worktrees). Add a function that finds either type of path and returns the nearest.
3 participants
Some anchor paths can be files or directories (e.g.,
.gitis a directory normally, but a file for worktrees). Add a function that finds either type of path and returns the nearest.Cc: @rymdbar