Departure Trilogy support

[mldoscar]

No description provided.

[mldoscar]

@guilleiguaran @benlangfeld Can you please take a look at this PR?

• Added trilogy support without the need to depend on any mysql2 connections

• Kept mysql2 support

• Spec pass locally

• Rubocop passing locally

[benlangfeld]

@guilleiguaran @benlangfeld Can you please take a look at this PR?

• Added trilogy support without the need to depend on any mysql2 connections

• Kept mysql2 support

• Spec pass locally

• Rubocop passing locally

This is more up @xjunior 's street. He's been working on things related to this recently.

[mldoscar]

Thanks for the quick response. @xjunior I'll appreciate if you can take a look. This work was inspired on your previous PR, this PR makes trilogy to work as a standalone adapter without depending on mysql2 adapter

[douglas]

Hello @mldoscar ! I just tried your branch on Rails 7.1 and I'm hitting this problem when running migrations: #110

Are you seeing the same there?

[mldoscar]

Hello @mldoscar ! I just tried your branch on Rails 7.1 and I'm hitting this problem when running migrations: #110

Are you seeing the same there?

You are right, I am seeing the same in rails 7.1. I'll dig more into it and I'll post a feedback in this thread. Might take some time but definitely this is something I'll have to take a deeper look at in a near future

[douglas]

@mldoscar thanks a lot, I think your PR improved a lot of things in the codebase and if we could get that part to work it would be amazing.

Since there is no additional connection, perhaps we could actually make Departure a full-fledged AR adapter? This way, we don't need to care about changing adapters during migration and it should be closer to what AR expects since the change I mentioned in that thread.

In any case, count on me if you need any help 👍

[xjunior]

Is this any useful in this setup? We should probably get rid of this line.

[xjunior]

@mldoscar thanks a lot, I think your PR improved a lot of things in the codebase and if we could get that part to work it would be amazing.

Since there is no additional connection, perhaps we could actually make Departure a full-fledged AR adapter? This way, we don't need to care about changing adapters during migration and it should be closer to what AR expects since the change I mentioned in that thread.

In any case, count on me if you need any help 👍

Can you elaborate on how that would be possible?

[xjunior]

@mldoscar are you still working on this? We merged rails 7.1 and 7.2 support to main, which included refactorings that conflicted with your branch, but should also contribute to your solution.

We're excited to support Trilogy, so please let us know if you're not going to be working on this.

[mldoscar]

@xjunior I can try to rebase my branch and work on the trilogy compatibility based on the recent changes in the master branch at some point