Publish gems using the version of RubyGems specified in Dockerfile.updater-core
#12036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
markhallen
approved these changes
Apr 12, 2025
…pdater-core` Rather than inheriting the version of RubyGems bundled with Ruby, let's explicitly match the version of RubyGems specified in `Dockerfile.update-core`, as this is what the rest of our prod/CI systems are using. So this feels a bit safer. It's also more flexible because it lets us explicitly manage the version of RubyGems. I think this is a good idea overall, but the specific need for this arose because the `--attestations` flag was only recently added to the `gem push` command. So we need a newer version of RubyGems than is bundled with the version of Ruby currently used by this repo (3.3). It turns out that we already use a newer version, so we just need to wire that up into this workflow as well.
jeffwidman
force-pushed
the
match-the-rubygems-version-to-the-rest-of-the-codebase
branch
from
c678e3c to
fc54620
Compare
jeffwidman
deleted the
match-the-rubygems-version-to-the-rest-of-the-codebase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than inheriting the version of RubyGems bundled with Ruby, let's explicitly match the version of RubyGems specified in
Dockerfile.update-core:I think this is a good idea overall, but the specific need for this arose because the
--attestationsflag was only recently added to thegem pushcommand. So we need this for my recently merged Sigstore attestations PR:Luckily, @deivid-rodriguez already put in the effort to update the RubyGems version, so we just need to wire that up into this workflow as well:
Until this PR is merged, we cannot publish our gems.