-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Consolidate docker_compose into docker directory #13834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 19 commits
c9de1c7
9ae07a7
3337dc9
2aba739
09d33e1
272b2a2
a1e376d
af70608
72a98c8
b5aa08b
8b7b0c7
2c7c6ef
1126949
2a117f6
b4f78d1
22b51a8
31b3151
0f9fd85
443a2bd
fdce4d9
03b7dad
ad8ac01
367e5a3
633c35a
0face80
381e5dc
aa36ec5
ca35646
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,12 +20,12 @@ jobs: | |
| - { path: bun, name: bun, ecosystem: bun } | ||
| - { path: bundler, name: bundler, ecosystem: bundler } | ||
| - { path: cargo, name: cargo, ecosystem: cargo } | ||
| - { path: common, name: common, ecosystem: common} | ||
| - { path: common, name: common, ecosystem: common } | ||
| - { path: composer, name: composer, ecosystem: composer } | ||
| - { path: conda, name: conda, ecosystem: conda } | ||
| - { path: devcontainers, name: devcontainers, ecosystem: devcontainers } | ||
| - { path: docker_compose, name: docker_compose, ecosystem: docker-compose } | ||
| - { path: docker, name: docker, ecosystem: docker } | ||
| - { path: docker, name: docker_compose, ecosystem: docker-compose, build: docker_compose } | ||
| - { path: dotnet_sdk, name: dotnet_sdk, ecosystem: dotnet-sdk } | ||
| - { path: elm, name: elm, ecosystem: elm } | ||
| - { path: git_submodules, name: git_submodules, ecosystem: gitsubmodule } | ||
|
|
@@ -38,13 +38,13 @@ jobs: | |
| - { path: maven, name: maven, ecosystem: maven } | ||
| - { path: npm_and_yarn, name: npm_and_yarn, ecosystem: npm } | ||
| - { path: nuget, name: nuget, ecosystem: nuget } | ||
| - { path: opentofu, name: opentofu, ecosystem: opentofu } | ||
| - { path: pub, name: pub, ecosystem: pub } | ||
| - { path: python, name: python_slow, ecosystem: pip } | ||
| - { path: python, name: python, ecosystem: pip } | ||
| - { path: python, name: python_slow, ecosystem: pip } | ||
| - { path: rust_toolchain, name: rust_toolchain, ecosystem: rust-toolchain } | ||
| - { path: swift, name: swift, ecosystem: swift } | ||
| - { path: terraform, name: terraform, ecosystem: terraform } | ||
| - { path: opentofu, name: opentofu, ecosystem: opentofu } | ||
| - { path: uv, name: uv, ecosystem: uv } | ||
| - { path: vcpkg, name: vcpkg, ecosystem: vcpkg } | ||
|
|
||
|
|
@@ -63,7 +63,7 @@ jobs: | |
|
|
||
| - name: Build ecosystem image | ||
| if: steps.changes.outputs[matrix.suite.path] == 'true' | ||
| run: script/build ${{ matrix.suite.path }} | ||
| run: script/build ${{ matrix.suite.build || matrix.suite.path }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @robaiken , are this similar things? Is there a reason now we are before trying to capture the build path?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To avoid breaking the other filters, adding a new parameter was the simplest approach. While not ideal, refactoring the entire CI matrix would be beyond the scope of this work, especially given that this PR is already quite large. |
||
|
|
||
| - name: Run ${{ matrix.suite.name }} tests | ||
| if: steps.changes.outputs[matrix.suite.path] == 'true' | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robaiken , I think we can add filter like following