Skip to content

docs: drop redundant text in the Internet Access Required section#7521

Merged
jeremylong merged 2 commits intodependency-check:mainfrom
brlin-tw:patch-1
Mar 12, 2025
Merged

docs: drop redundant text in the Internet Access Required section#7521
jeremylong merged 2 commits intodependency-check:mainfrom
brlin-tw:patch-1

Conversation

@brlin-tw
Copy link
Contributor

Description of Change

This pull request fixes a trivial writing error in the introductory text of the Internet Access Required – dependency-check-maven page.

Please take a look at the diff for the problem.

Related issues

N/A

Have test cases been added to cover the new functionality?

N/A

@boring-cyborg boring-cyborg bot added the documentation site documentation label Mar 12, 2025
@aikebah
Copy link
Collaborator

aikebah commented Mar 12, 2025

I should mention I'm not a native English speaker, but I do get the impression that you dropped the wrong duplicate for arriving at non-redundant language.

@jeremylong would the proposed new text be correct to native speakers or should we drop the initial requires access and leave the one that was removed in place?

@jeremylong jeremylong added this to the 12.1.1 milestone Mar 12, 2025
@jeremylong jeremylong merged commit cbc874f into dependency-check:main Mar 12, 2025
2 checks passed
@brlin-tw
Copy link
Contributor Author

@aikebah Thanks for the correction!

@brlin-tw brlin-tw deleted the patch-1 branch March 13, 2025 02:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation site documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants