fix: Resolve various WCAG accessibility / css issues in the HTML report#7629
Merged
jeremylong merged 3 commits intomainfrom May 5, 2025
Merged
fix: Resolve various WCAG accessibility / css issues in the HTML report#7629jeremylong merged 3 commits intomainfrom
jeremylong merged 3 commits intomainfrom
Conversation
* Set the html lang attribute * Convert the summary table introductionary text into a description and move it into the table as the caption * Remove the duplicated .hidden css class rule Fixes issue #7618
* Revert the summary table introductionary text to the caption as it breaks keyboard navigation due to the way the JQuery stupidTable plugin works * Adapt the original summary text intro into one that is useable to provide the table description as an aria-labelledby and adapt the vulnerabilityDisplayToggle onClick event accordingly Fixes issue #7618
…bility checker Firefox reported a too low contrast ratio (3.85), darkened the disclaimer text to a contrast-ratio of 7.0 (WCAG AAA compliant)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Other items reported by Firefox are not taken up now, these concern the lack of proper keyboard support in the JQuery plugin that is currently used to make the summary table sortable. Resolving those would require replacement of the plugin by some other plugin that would offer full WCAG compliancy.
Related issues
Have test cases been added to cover the new functionality?
no, some base testing performed with Firefox and Safari using MacOS VoiceOver to check that navigation works and the table description gets used as expected.