-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: add hint for Elastic APM Java agent CPE mapping #8200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Does the change/hint work? What are the results before/after? |
|
Thanks @chadlwilson for the question. |
|
A simple "no" would be enough, if you haven't tested it. (Are your messages AI generated?) In my opinion, you should demonstrate evidence a non-trivial change actually has the intended effect when proposing it. |
|
@chadlwilson sir, |
|
@chadlwilson Sir, I tested the behavior before and after refining the hint. Before the hint, the Elastic APM Java agent was resolved only as the generic |
|
@chadlwilson I tested the behavior before and after refining the hint. can you please check the Screenshots ? so it will help me to clear pov . |
|
@Umesh042005 thanks Umesh, I'll take a look soon 👍 |
chadlwilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (this was a quick one, dont know why I was procrastinating!)
Co-authored-by: Chad Wilson <[email protected]>
|
Hi @chadlwilson chadlwilson, I have applied the suggested tweak for consistency. Could you please approve the workflows to run the final checks? Thanks |
|
I’m just a contributor & issue trigger - I don’t have maintenance permissions. |
|
sorry for the delay - I've been extremely busy. I'll try to get a few of the PRs (like this one) merged in the next week and create a new release. |
|
@Umesh042005 the failing test is not due to your change. If you rebase on current master, or merge from master it should be fixed. |
|
"Hi @chadlwilson , @jeremylong , I have merged the latest changes from the master branch as suggested. The previous build failure is now resolved. Could you please approve the workflows to run the final checks? Thank you!" |



Description of Change
This change adds a small hint to help Dependency-Check correctly
identify the Elastic APM Java agent as
apm_java_agent.Without this hint, the Java agent may be matched to the generic
elastic:apm_agent, which can cause Java-specific CVEs to be missed.Related issues
Relates to #8008
Have test cases been added to cover the new functionality?
No