Lint sources on PHP 7.x via Github Action #4016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice! Should we fix php8 file to be php7?
Can be skipped. But |
Contributor
Author
|
sure - here you are |
clxmstaab
pushed a commit
to staabm/deployer
that referenced
this pull request
Feb 10, 2025
* Lint sources on PHP 7.x via Github Action * Skip PHP8 only files * Fix PHP7 compat in rc/Component/PharUpdate/Update.php * Simplify workflow * Simplify even more
clxmstaab
pushed a commit
to staabm/deployer
that referenced
this pull request
Feb 10, 2025
antonmedv
added a commit
that referenced
this pull request
Feb 10, 2025
* Lint sources on PHP 8.2 via Github Action (#4016) * Update lint.yml * Update lint.yml --------- Co-authored-by: Anton Medvedev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new Github Action workflow via lints against PHP 7.x to prevent problems like #3976 which got fixed in f1f7b61
the newly added check skips the following files, as these currently contain PHP8+ only syntax: