Skip to content

Add array_is_list polyfill for backward compatibility #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonmedv merged 3 commits into from
Feb 11, 2025
Merged

Add array_is_list polyfill for backward compatibility #4019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ede999
Add array_is_list polyfill for backward compatibility
NickVulkers Feb 11, 2025
ac3deec
Add array_is_list polyfill to helpers, and use it for magento2 recipe
NickVulkers Feb 11, 2025
cd71a4a
New line for opening brace
NickVulkers Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions recipe/magento2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
use Deployer\Exception\RunException;
use Deployer\Host\Host;

use function Deployer\Support\array_is_list;

const CONFIG_IMPORT_NEEDED_EXIT_CODE = 2;
const DB_UPDATE_NEEDED_EXIT_CODE = 2;
const MAINTENANCE_MODE_ACTIVE_OUTPUT_MSG = 'maintenance mode is active';
Expand Down
12 changes: 12 additions & 0 deletions src/Support/helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,18 @@ function array_merge_alternate(array $original, array $override)
return $original;
}

/**
* Polyfill for the array_is_list function introduced in PHP 8.1.
*
* @param array $array The array to check.
* @return bool Returns true if the array is a list, false otherwise.
*/
function array_is_list(array $array): bool
{
$keys = array_keys($array);
return $keys === array_keys($keys);
}

/**
* Determines if the given string contains the given value.
*/
Expand Down