Skip to content

add-apt-repository pre-requisites #4054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonmedv merged 3 commits into from
Apr 7, 2025
Merged

add-apt-repository pre-requisites #4054

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08c911f
Install `provision:update` pre-requisites
Max13 Apr 6, 2025
6d4f307
`add-apt-repository` is broken with non-UTF-8 locales
Max13 Apr 6, 2025
15e0d93
Moves env var to env
Max13 Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion recipe/provision.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,14 @@
task('provision:update', function () {
set('remote_user', get('provision_user'));

// Update before installing anything
run('apt-get update', env: ['DEBIAN_FRONTEND' => 'noninteractive']);

// Pre-requisites
run('apt install -y curl gpg software-properties-common', env: ['DEBIAN_FRONTEND' => 'noninteractive']);

// PHP
run('apt-add-repository ppa:ondrej/php -y', env: ['DEBIAN_FRONTEND' => 'noninteractive']);
run('LC_ALL=C.UTF-8 apt-add-repository ppa:ondrej/php -y', env: ['DEBIAN_FRONTEND' => 'noninteractive']);
Copy link
Member

@antonmedv antonmedv Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move it to env.

Also why this was added? Usually it is default.

Copy link
Contributor Author

@Max13 Max13 Apr 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a fresh install on Ubuntu 24.04, on LXC on Proxmox, default is C.

deployer@test:~/parcourbot$ locale
LANG=C
LANGUAGE=
LC_CTYPE="C"
LC_NUMERIC="C"
LC_TIME="C"
LC_COLLATE="C"
LC_MONETARY="C"
LC_MESSAGES="C"
LC_PAPER="C"
LC_NAME="C"
LC_ADDRESS="C"
LC_TELEPHONE="C"
LC_MEASUREMENT="C"
LC_IDENTIFICATION="C"
LC_ALL=

Specifying it would not cause anything in case C.UTF-8 is the default, and fix things if it's not.


// Caddy
run("curl -1sLf 'https://dl.cloudsmith.io/public/caddy/stable/gpg.key' | gpg --dearmor --yes -o /usr/share/keyrings/caddy-stable-archive-keyring.gpg");
Expand Down
Loading