Skip to content

Mark finished release and don't consider un-finished releases in rollback #4115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Mark finished release and don't consider un-finished releases in rollback #4115

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
72c0031
mark release as finished and only consider finished releases during r…
pableu Sep 16, 2025
db0f5f5
show unfinished releases in "dep releases"
pableu Sep 16, 2025
52566a9
fix showing unfinished releases
pableu Sep 16, 2025
47a5070
Remove finished release task from deployment
antonmedv Oct 28, 2025
c282198
fix coding standard in rollback.php
pableu Oct 30, 2025
ec1ce6f
Update rollback.md
pableu Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions recipe/deploy/release.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@
$status = "<error>$release</error> (bad)";
} elseif (test("[ -f releases/$release/DIRTY_RELEASE ]")) {
$status = "<error>$release</error> (dirty)";
} elseif (!test("[ -f releases/$release/FINISHED_RELEASE ]")) {
$status = "<error>$release</error> (unfinished)";
} else {
$status = "<info>$release</info>";
}
Expand Down
8 changes: 6 additions & 2 deletions recipe/deploy/rollback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,12 @@
while (isset($releasesBeforeCurrent[0])) {
$candidate = $releasesBeforeCurrent[0];

// Skip all bad releases.
if (test("[ -f {{deploy_path}}/releases/$candidate/BAD_RELEASE ]")) {
if (
// Only consider successful releases.
!test("[ -f {{deploy_path}}/releases/$candidate/FINISHED_RELEASE ]")
// Skip all bad releases (that have previously been rolled back).
|| test("[ -f {{deploy_path}}/releases/$candidate/BAD_RELEASE ]")
) {
array_shift($releasesBeforeCurrent);
continue;
}
Expand Down
2 changes: 2 additions & 0 deletions recipe/deploy/symlink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,6 @@
run("cd {{deploy_path}} && {{bin/symlink}} {{release_path}} {{current_path}}"); // Atomic override symlink.
run("cd {{deploy_path}} && rm release"); // Remove release link.
}

run("echo '{{user}}' > {{release_path}}/FINISHED_RELEASE");
});
Loading