Skip to content

bug: 세션 업데이트에 누락된 필드도 업데이트한다 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddingmin merged 2 commits into from
Mar 26, 2025
Merged

bug: 세션 업데이트에 누락된 필드도 업데이트한다 #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
384cb34
feat: 세션 업데이트에 누락된 필드들 추가
ddingmin Mar 26, 2025
75f008a
feat: 세션 request dto에 validation 로직 추가
ddingmin Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/kotlin/com/depromeet/makers/presentation/web/SessionController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ class SessionController(
): SessionResponse {
val session = sessionService.updateSession(
sessionId = ObjectId(sessionId),
generation = request.generation,
week = request.week,
title = request.title,
description = request.description,
place = request.place,
Expand Down
7 changes: 6 additions & 1 deletion src/main/kotlin/com/depromeet/makers/presentation/web/dto/request/SessionRequest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ data class SessionRequest(
val place: SessionPlace?,
val startTime: LocalDateTime,
val endTime: LocalDateTime,
)
) {
init {
require(generation > 0) { "generation must be greater than 0" }
require(week > 0) { "week must be greater than 0" }
}
}

data class SessionGenerationRequest(
val generation: Int,
Expand Down
4 changes: 4 additions & 0 deletions src/main/kotlin/com/depromeet/makers/service/SessionService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ class SessionService(

fun updateSession(
sessionId: ObjectId,
generation: Int,
week: Int,
title: String,
description: String,
place: SessionPlace?,
Expand All @@ -59,6 +61,8 @@ class SessionService(
): Session {
val session = sessionRepository.findByIdOrNull(sessionId) ?: throw DomainException(ErrorCode.NOT_FOUND)
session.update(
generation = generation,
week = week,
title = title,
description = description,
place = place,
Expand Down