You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry, but I don't actually understand, what is happening in the changes you submitted. Could you please describe, why must we use the currently opened log file last modification date and time instead of current date? The modification datetime will be anyway updated to meet the current datetime after writing the log record once :)
I need this change, it's very useful. But still your commit has a problem - the last append goes to the old logfile.
this will be work.
QDateTime now;
if (m_rollOverTime.isNull()) {
QFileInfo fileInfo = QFileInfo(fileName());
if (fileInfo.isFile()) {
now = fileInfo.lastModified();
}
}
if (!now.isValid() || now > QDateTime::currentDateTime()) {
now = QDateTime::currentDateTime();
}
I need this change, it's very useful. But still your commit has a problem - the last append goes to the old logfile.
this will be work.
QDateTime now;
if (m_rollOverTime.isNull()) {
QFileInfo fileInfo = QFileInfo(fileName());
if (fileInfo.isFile()) {
now = fileInfo.lastModified();
}
}
if (!now.isValid() || now > QDateTime::currentDateTime()) {
now = QDateTime::currentDateTime();
}
thanks, it works for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rolling is working if the application is not shutdown over night (for daily).
Solved by getting the modification time from file if it exists when starting the application and using it instead of now.