fix: top bar with action menu incorrect div[role=presentation] #2204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an HTML accessibility issue where a div[role=presentation] was being incorrectly placed as a direct child of ul[role=menubar] when using TopBar with ActionMenu. The fix moves the menu overlay back inside the trigger element and adds aria-hidden and hidden attributes to prevent regression with issue #2148.
Changes:
- Updated
ActionMenucomponent to addmenuId,aria-controls,aria-hidden, andhiddenattributes for better accessibility - Modified documentation and examples to render the menu as a child of
TopBarIteminstead of as a sibling - Removed the accessibility note that is no longer applicable with this implementation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react/src/components/ActionMenu/ActionMenu.tsx | Added menuId generation, aria-controls attribute to trigger, aria-hidden to overlay, and hidden prop to menu list for proper accessibility when using renderInTrigger |
| docs/pages/components/TopBar.mdx | Updated examples to render menu inside TopBarItem and removed outdated accessibility note |
| docs/index.js | Updated example to render menu inside TopBarItem consistent with the new pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
chornonoh-vova
force-pushed
the
fix/top-bar-with-action-menu-aria-required-children
branch
from
a2f8739 to
f1f99ca
Compare
After expanding the submenu, remove bottom border of "Menu" menu item. Also on shift+tab from submenu items, that is when the user lands on "Menu" menu item, made sure the border reappears and sub menu is collapsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
div[role=presentation]is inside theuland not a list item, it is not allowed (when usingTopBarwithActionMenu)Move it back in and added
aria-hiddenandhiddento not cause regression with #2148.