fix(styles): Fixed Link component with Icon to stretch inside flex container
#2205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a layout issue where Link components containing Icons were stretching to fill the full width of their parent flex containers. The fix applies CSS properties to constrain the Link to its content size and prevent unwanted cross-axis stretching.
Changes:
- Added
width: max-contentto constrain Link width to content size - Added
align-self: flex-startto prevent stretching in flex containers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Link component with Icon stretching to full width inside flex containers
align-self: flex-start- prevents cross-axis stretching in flex containers;width: max-content- ensures width is constrained to content size;Before (stretched to the full width)
After (content sized)
Closes: https://github.com/dequelabs/walnut/issues/13196