fix: combobox double tab #2208
Open
fix: combobox double tab #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a keyboard navigation issue in the Combobox component where pressing Tab would cause focus to jump from the input element to the listbox and then disappear, creating a confusing user experience.
Changes:
- Modified the
tabIndexattribute of the listbox to be-1when matching options exist, preventing it from receiving focus during keyboard navigation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/dequelabs/axe-extension/issues/6942
When using
listboxinside a combobox with a keyboard, it does a doubletabfirst focusing on the comboboxinputelement and then quietly on thelistboxwith the focus disappearing. The issue is originally from theaxe-extensionbut I also was able to replicate it on the cauldron components page with the grouped combobox.Before:
Details
Screen.Recording.2026-01-21.at.1.22.56.PM.mov
After:
Details
Screen.Recording.2026-01-21.at.1.22.08.PM.mov