Dont just create but check if exists or not#573
Open
s4mur4i wants to merge 1 commit intoderailed:masterfrom
Open
Dont just create but check if exists or not#573s4mur4i wants to merge 1 commit intoderailed:masterfrom
s4mur4i wants to merge 1 commit intoderailed:masterfrom
Conversation
Author
|
@derailed Can we have check on the PR if you have possibility please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were updating and v0.21.6, and one behaviour change we noticed is that we always try to create, and see if we get already exists.
For our use case this is not a good practice, so implemented a headbucket call.
We dont provide popeye with permission to create buckets, but create buckets through IaC.
We dont want to give popeye any permission to create buckets, as there is no requirement for it, and it will be flagged as an unused permission from iam access analyzer.
This just implements a headbucket logic, to check if bucket exists or not. if it does it continues. If we use this method then the createbucket logic can also be simplified, since we dont need to test if exists or not, but i didnt think I should decide alone on it, or maybe it can be improved in seperate pr.