Fix "Cannot use bool as array" error in ImageValidationTrait

[dereuromark]

Summary

• Handle getimagesize() returning false for non-image files
• Add isValidImage() method for clearer error messages

Problem

When a file passes the upload validation (UPLOAD_ERR_OK) but is not a valid image (e.g., PDF, corrupted file, unsupported format), getimagesize() returns false.

The current code uses array destructuring directly on the result:

[$imgWidth] = getimagesize($file);

This causes a fatal error:

Cannot use bool as array in ImageValidationTrait.php on line 28

Additionally, if the error is handled, users get confusing messages like "This image should at least be 50px wide" for non-image uploads.

Solution

1. Fix the crash: Store the result and check for false before accessing dimensions in all four dimension methods.

2. Add isValidImage() method: Allows explicit validation before dimension checks, enabling clear messages like "File must be a valid image (JPEG, PNG, GIF, or WebP)".

Usage

$validator->add('file', 'fileIsValidImage', [
    'rule' => 'isValidImage',
    'message' => 'File must be a valid image (JPEG, PNG, GIF, or WebP)',
    'provider' => 'upload',
]);

// Or with custom allowed types:
$validator->add('file', 'fileIsValidImage', [
    'rule' => ['isValidImage', [IMAGETYPE_JPEG, IMAGETYPE_PNG]],
    'message' => 'File must be a JPEG or PNG image',
    'provider' => 'upload',
]);

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.01%. Comparing base (5d49fd4) to head (58594f3).

Files with missing lines	Patch %	Lines
src/Model/Validation/ImageValidationTrait.php	96.42%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
+ Coverage     71.82%   73.01%   +1.19%     
- Complexity      231      241      +10     
============================================
  Files            14       14              
  Lines           788      808      +20     
============================================
+ Hits            566      590      +24     
+ Misses          222      218       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.