Skip to content

Fix null array offset deprecation in PHP 8.5 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 2 commits into from
Feb 7, 2026
Merged

Fix null array offset deprecation in PHP 8.5 #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57c807b
Fix null array offset deprecation in PHP 8.5
dereuromark Feb 7, 2026
907d797
Fix PHPStan error with nullable return type
dereuromark Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Auth/AclTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ protected function _check(array $userRoles, array $params) {
}

$iniKey = $this->_constructIniKey($params);
if (empty($this->_acl[$iniKey])) {
if ($iniKey === null || empty($this->_acl[$iniKey])) {
return false;
}

Expand Down Expand Up @@ -420,10 +420,13 @@ protected function _deconstructIniKey($key) {
* Constructs an ACL INI section key from a given Request.
*
* @param array $params The request params
* @return string Hash with named keys for controller, plugin and prefix
* @return string|null Hash with named keys for controller, plugin and prefix
*/
protected function _constructIniKey($params) {
$res = $params['controller'];
protected function _constructIniKey($params): ?string {
$res = $params['controller'] ?? null;
if ($res === null) {
return null;
}
if (!empty($params['prefix'])) {
$res = $params['prefix'] . "/$res";
}
Expand Down