Specify cross compilation target #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHP configure script makes decisions based on the target CPU (e.g. whether to enable JIT). When cross compiling we need to specify which host-system we are building for, with --host=. emconfigure doesn't to it automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP configure script makes decisions based on the target CPU (e.g. whether to enable JIT). When cross compiling we need to specify which host-system we are building for, with
--host=, otherwise the configure script assumes it's the same as the build machine.emconfigure doesn't pass
--hostautomatically.--hostaffects variables such as$host_cpu. We inspect this variable as least to determine whether to enable JIT: https://github.com/php/php-src/blob/98e0dbcefedeecf5e4d032e54df1aeebaa118754/ext/opcache/config.m4#L26-L30. When not passing--host, JIT may be enabled when the target is not supported, which fails later: https://github.com/php/php-src/blob/98e0dbcefedeecf5e4d032e54df1aeebaa118754/ext/opcache/jit/zend_jit.h#L29.Along with php/php-src#19350, this fixes the build for alpha4.