Ensure favicon and content url has origin #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ariansvi
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a utility function,
ensureUrlHasOrigin, to standardize handling of URLs by ensuring they include an origin. The function is integrated into multiple parts of the application to simplify and improve URL processing.Addition of
ensureUrlHasOriginutility:src/utils/url.ts: Added a new utility function,ensureUrlHasOrigin, which prepends the current window's origin to relative URLs or returns the original URL if it already includes an origin.Integration of
ensureUrlHasOrigin:src/App.tsx: Updated thefaviconUrlTemplateto useensureUrlHasOriginfor consistent origin handling when constructing the favicon URL.src/index.tsx: Replaced manual logic for constructingcontentBaseUrlwith theensureUrlHasOriginutility for cleaner and more reliable URL processing.Import updates:
src/App.tsx: Added an import forensureUrlHasOriginto use the new utility.src/index.tsx: Added an import forensureUrlHasOriginto facilitate its usage.