feat: add additional login ids param to the patch#709
Merged
Conversation
batch and singular patch requests + tests fixes #707
|
🐕 Review complete — View session on Shuni Portal 🐾 |
dorsha
approved these changes
Mar 27, 2026
aviadl
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the management user patch APIs to support the newly available additionalIdentifiers field (Issue #707), including both single-user and batch patch operations, with accompanying Jest coverage.
Changes:
- Add
additionalIdentifiers?: string[]toPatchUserOptions. - Include
additionalIdentifiersin the patch request body builder so it’s sent for bothpatchandpatchBatch. - Extend existing unit tests to assert the field is passed through correctly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/management/user.ts | Adds additionalIdentifiers to PatchUserOptions and serializes it into patch request bodies. |
| lib/management/user.test.ts | Adds expectations for additionalIdentifiers in both singular patch and batch patch tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batch and singular patch requests
fixes PatchUserOptions support for additionalIdentifiers #707