feat: adding Save/Load FGA Resources Details MGMT APIs#562
Merged
Conversation
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/common.py
descope/management/fga.py
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Save and Load FGA Resources Details Management APIs. It includes new client methods in the management module, corresponding endpoints in the common module, and tests covering both success and error scenarios.
- Added load_resources_details and save_resources_details methods to DescopeClient.
- Introduced corresponding endpoints in common.py.
- Implemented tests for both success and error cases for the new APIs.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/management/test_fga.py | Added tests for load and save FGA resources details API behavior. |
| descope/management/fga.py | Implemented API client methods for loading and saving resource details. |
| descope/management/common.py | Added new endpoint definitions for loading and saving resources. |
Comments suppressed due to low confidence (1)
tests/management/test_fga.py:231
- [nitpick] The variable name 'ids' is ambiguous given the context; renaming it to 'resource_identifiers' may improve clarity and consistency with the API method signature.
ids = [
guyp-descope
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for: https://github.com/descope/etc/issues/9671
Related PRs
Depends on: https://github.com/descope/managementservice/pull/2083
Description
Adding support for Save & Load FGA Resources Details MGMT APIs
Must