feat: add async support and tests for Descope SDK #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `async_demo_app.py` to demonstrate async capabilities of the Descope SDK. - Added `asyncer` dependency to `pyproject.toml`. - Updated coverage threshold to 97. - Created comprehensive tests for async methods in `test_async.py`. - Refactored existing tests for better readability and consistency. - Enhanced error handling in async methods.
Updated the claims storage mechanism in multiple functions to use Flask's g object instead of _request_ctx_stack. This change improves the clarity and consistency of the code by utilizing the recommended context management approach in Flask.
omercnet
changed the title
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/descope_client_async.py
descope/auth.py
descope/management/jwt.py
descope/init.py
|
|
When using this I get no typehints or autocomplete. is this the same with your local setup? |
Wiz Scan SummaryDisplaying only findings that violated a policy
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an asynchronous demo application to showcase the async capabilities of the Descope SDK. Enhance error handling in async methods and add comprehensive tests for these methods. Update the coverage threshold and refactor existing tests for improved readability. Include the
asyncerdependency for async functionality.