Skip to content

Conversation

@gaokevin1
Copy link
Member

@gaokevin1 gaokevin1 commented Jul 28, 2025

Related Issues

Fixes https://github.com/descope/etc/issues/11531

Related PRs

branch PR
service a PR Link to PR
service b PR Link to PR

Description

Added outbound app management functions, along with user/tenant token retrieval functions to the Python SDK.

This will be used by the MCP Python SDK to fetch outbound app tokens.

This PR also include the functionality for fetching outbound app tokens by using inbound app tokens with scope "outbound.token.fetch"

Must

  • Tests
  • Documentation (if applicable)

@github-actions
Copy link

github-actions bot commented Jul 28, 2025

Coverage report

The coverage rate went from 97.65% to 97.75% ⬆️

99.37% of new lines are covered.

Diff Coverage details (click to unfold)

descope/auth.py

100% of new lines are covered (95.63% of the complete file).

descope/mgmt.py

100% of new lines are covered (100% of the complete file).

descope/management/jwt.py

100% of new lines are covered (100% of the complete file).

descope/management/common.py

96.42% of new lines are covered (99.15% of the complete file).
Missing lines: 28

descope/management/fga.py

100% of new lines are covered (100% of the complete file).

descope/management/outbound_application.py

100% of new lines are covered (100% of the complete file).

slavikm
slavikm previously approved these changes Jul 28, 2025
@guyp-descope
Copy link
Contributor

@gaokevin1 is there a reason why the create/update functions missing many outbound application params?
see in Node sdk all the param list for example: https://github.com/descope/node-sdk/blob/main/lib/management/types.ts#L933

@guyp-descope guyp-descope requested a review from orius123 August 11, 2025 16:28
Copy link
Member

@orius123 orius123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaokevin1
Copy link
Member Author

I just tested the inbound app functions and those work well. @guyp-descope I cannot approve my own PR, but please approve this and let's merge this ASAP.

@guyp-descope guyp-descope enabled auto-merge (squash) August 12, 2025 08:13
@guyp-descope guyp-descope self-requested a review August 12, 2025 08:15
@guyp-descope guyp-descope merged commit c751b1e into main Aug 12, 2025
24 checks passed
@guyp-descope guyp-descope deleted the outbound-apps branch August 12, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants