Fix projectId init by env var + lint fixes #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes project ID initialization from environment variables and applies various linting fixes to improve code formatting consistency across the codebase.
Key changes:
- Fixed project ID initialization to properly read from
DESCOPE_PROJECT_IDenvironment variable inHTTPClient - Applied automatic code formatting fixes (line length, trailing commas, import ordering)
- Removed unused imports
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| descope/http_client.py | Added environment variable fallback for project_id initialization with improved error messaging |
| descope/auth.py | Removed unused requests import |
| descope/management/tenant.py | Fixed import ordering and formatting of method parameters |
| descope/management/common.py | Added blank lines between class definitions per PEP 8 |
| tests/test_http_client.py | Added test case for project ID initialization from environment variable |
| tests/test_jwt_common.py | Removed unused generate_auth_info import |
| tests/test_auth.py | Applied formatting fixes to test methods (line breaks, trailing commas) |
| tests/management/test_tenant.py | Applied formatting fixes to method call arguments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/descope_client.py
descope/management/tenant.py
|
itaihanski
reviewed
Nov 11, 2025
Member
itaihanski
left a comment
itaihanski
left a comment
There was a problem hiding this comment.
Looks good - one suggestion
itaihanski
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.