Skip to content

Conversation

@ruvenzx
Copy link
Contributor

@ruvenzx ruvenzx commented Jan 1, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for SSO exclusions and federated application IDs to tenant management operations. The changes fix issue #13503 by extending the tenant create, update, and update_settings methods to support enforce_sso_exclusions (list of user IDs excluded from SSO enforcement) and federated_app_ids (list of federated application IDs).

  • Adds two new optional parameters to tenant create, update, and update_settings methods
  • Updates parameter documentation for all affected methods
  • Adds comprehensive test coverage for the new parameters in create and update operations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
descope/management/tenant.py Adds enforce_sso_exclusions and federated_app_ids parameters to create, update, and update_settings methods with corresponding API body mapping
tests/management/test_tenant.py Adds test coverage for the new parameters in tenant create and update operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +130 to +132
enforce_sso: Optional[bool] = None,
enforce_sso_exclusions: Optional[List[str]] = None,
federated_app_ids: Optional[List[str]] = None,
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new parameters enforce_sso, enforce_sso_exclusions, and federated_app_ids added to the update_settings method lack test coverage. While tests exist for test_update_settings, they don't verify these newly added parameters. Consider adding a test case that calls update_settings with these parameters and verifies they are correctly included in the request body.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Coverage report

The coverage rate went from 98.35% to 98.35% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

descope/management/tenant.py

100% of new lines are covered (100% of the complete file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants