Feat: Unify toast notifications and improve avatar display #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two main improvements:
1. **Unified Toast Notifications:**
The success notifications on the profile and password update pages have been unified to use the `sonner` toast component. This replaces the simple text-based message and provides a more modern and consistent user experience across the application.
2. **Improved Avatar Display:**
- The `User` model has been updated to use an accessor for the `avatar` attribute. This ensures that a valid avatar URL is always available, with a fallback to `ui-avatars.com` if the user has not uploaded a custom avatar.
- The `avatar-upload.tsx` component has been updated to use the `Avatar` component, which is consistent with other parts of the application and provides a better fallback mechanism.
This commit introduces two main improvements:
1. **Unified Toast Notifications:**
The success notifications on the profile and password update pages have been unified to use the `sonner` toast component. This replaces the simple text-based message and provides a more modern and consistent user experience across the application.
2. **Improved Avatar Display:**
- The `User` model has been updated to use an accessor for the `avatar` attribute. This ensures that a valid avatar URL is always available, with a fallback to `ui-avatars.com` if the user has not uploaded a custom avatar.
- The `avatar-upload.tsx` component has been updated to use the `Avatar` component, which is consistent with other parts of the application and provides a better fallback mechanism.
- The `AvatarImage` component now uses `object-cover` to prevent the avatar from being stretched.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the toast notifications for profile and password updates using the
sonnercomponent and improves the avatar display by ensuring a consistent fallback mechanism and preventing the image from being stretched.PR created automatically by Jules for task 1677866934729211729