Skip to content

Ln/update get highest bid lowest ask #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lazynina merged 2 commits into from
Nov 13, 2024
Merged

Ln/update get highest bid lowest ask #702

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f727049
invert orders as necessary
lazynina Nov 13, 2024
bcbdb32
Change function call to quote/base and review
diamondhands0 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions routes/dao_coin_exchange_with_fees.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,18 +1001,18 @@ func (fes *APIServer) GetQuoteCurrencyPriceInUsd(
}

func (fes *APIServer) GetHighestBidAndLowestAskPriceFromPKIDs(
coin1PKID *lib.PKID,
coin2PKID *lib.PKID,
basePkid *lib.PKID,
quotePkid *lib.PKID,
utxoView *lib.UtxoView,
initialHighestBidPrice float64,
) (float64, float64, float64, error) {
ordersBuyingCoin1, err := utxoView.GetAllDAOCoinLimitOrdersForThisDAOCoinPair(
coin1PKID, coin2PKID)
basePkid, quotePkid)
if err != nil {
return 0, 0, 0, fmt.Errorf("GetDAOCoinLimitOrders: Error getting limit orders: %v", err)
}
ordersBuyingCoin2, err := utxoView.GetAllDAOCoinLimitOrdersForThisDAOCoinPair(
coin2PKID, coin1PKID)
quotePkid, basePkid)
if err != nil {
return 0, 0, 0, fmt.Errorf("GetDAOCoinLimitOrders: Error getting limit orders: %v", err)
}
Expand All @@ -1033,12 +1033,26 @@ func (fes *APIServer) GetHighestBidAndLowestAskPriceFromPKIDs(
if err != nil {
return 0, 0, 0, fmt.Errorf("GetQuoteCurrencyPriceInUsd: Error parsing price: %v", err)
}

// Flip orders as needed.
appliedOperationType := order.OperationType
if order.OperationType == lib.DAOCoinLimitOrderOperationTypeBID &&
order.BuyingDAOCoinCreatorPKID.Eq(quotePkid) {
priceFloat = 1.0 / priceFloat
appliedOperationType = lib.DAOCoinLimitOrderOperationTypeASK
}
if order.OperationType == lib.DAOCoinLimitOrderOperationTypeASK &&
order.SellingDAOCoinCreatorPKID.Eq(quotePkid) {
priceFloat = 1.0 / priceFloat
appliedOperationType = lib.DAOCoinLimitOrderOperationTypeBID
}

if appliedOperationType == lib.DAOCoinLimitOrderOperationTypeBID &&
priceFloat > highestBidPrice {

highestBidPrice = priceFloat
}
if order.OperationType == lib.DAOCoinLimitOrderOperationTypeASK &&
if appliedOperationType == lib.DAOCoinLimitOrderOperationTypeASK &&
priceFloat < lowestAskPrice {

lowestAskPrice = priceFloat
Expand Down
Loading