Skip to content

add logic to prevent submitting transactions where fee rate is too high #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lazynina merged 1 commit into from
Nov 22, 2024
Merged

add logic to prevent submitting transactions where fee rate is too high #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions routes/transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,17 @@ func (fes *APIServer) SubmitAtomicTransaction(ww http.ResponseWriter, req *http.
innerTxnPreSignatureHashToSignature[*preSignatureInnerTxnHash]
}

atomicTxnLen, err := atomicTxn.ToBytes(false)
if err != nil {
_AddBadRequestError(ww, fmt.Sprintf(
"SubmitAtomicTransaction: Problem serializing completed atomic transaction: %v", err))
return
}
if TransactionFeeRateTooHigh(atomicTxn, uint64(len(atomicTxnLen))) {
_AddBadRequestError(ww, fmt.Sprintf("SubmitAtomicTransaction: Transaction fee rate too high"))
return
}

// Verify and broadcast the completed atomic transaction.
if err := fes.backendServer.VerifyAndBroadcastTransaction(atomicTxn); err != nil {
_AddBadRequestError(ww,
Expand Down Expand Up @@ -275,6 +286,19 @@ type SubmitTransactionResponse struct {
PostEntryResponse *PostEntryResponse
}

// FeeRateNanosPerKBThreshold is the threshold above which transactions will be rejected if the fee rate exceeds it.
const FeeRateNanosPerKBThreshold = 1e8

func TransactionFeeRateTooHigh(txn *lib.MsgDeSoTxn, txnLen uint64) bool {
// Handle base cases.
if txn.TxnFeeNanos == 0 || txnLen == 0 {
return false
}
// Compute the fee rate in nanos per KB.
feeRateNanosPerKB := (txn.TxnFeeNanos * 1000) / txnLen
return feeRateNanosPerKB > FeeRateNanosPerKBThreshold
}

func (fes *APIServer) SubmitTransaction(ww http.ResponseWriter, req *http.Request) {
decoder := json.NewDecoder(io.LimitReader(req.Body, MaxRequestBodySizeBytes))
requestData := SubmitTransactionRequest{}
Expand All @@ -296,6 +320,11 @@ func (fes *APIServer) SubmitTransaction(ww http.ResponseWriter, req *http.Reques
return
}

if TransactionFeeRateTooHigh(txn, uint64(len(txnBytes))) {
_AddBadRequestError(ww, fmt.Sprintf("SubmitTransactionRequest: Transaction fee rate too high"))
return
}

if err = fes.backendServer.VerifyAndBroadcastTransaction(txn); err != nil {
_AddBadRequestError(ww, fmt.Sprintf("SubmitTransaction: Problem processing transaction: %v", err))
return
Expand Down