Skip to content

Add/workflow for built files linter fixes #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desrosj merged 3 commits into from
Mar 11, 2025
+4 −6
Merged

Add/workflow for built files linter fixes #359

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79ce314
Replace inline GitHub Actions expressions with environment variables.
johnbillion Mar 11, 2025
253e168
Fix a linting issue.
johnbillion Mar 11, 2025
95d5bb1
Quote this parameter.
johnbillion Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/check-built-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,7 @@ jobs:
GH_APP_ID: ${{ secrets.GH_APP_ID }}
GH_APP_PRIVATE_KEY: ${{ secrets.GH_APP_PRIVATE_KEY }}
run: |
echo "${{ env.GH_APP_PRIVATE_KEY }}" > private-key.pem

APP_ID=${{ env.GH_APP_ID }}
echo "$GH_APP_PRIVATE_KEY" > private-key.pem

# Generate JWT
JWT=$(python3 - <<EOF
Expand All @@ -85,7 +83,7 @@ jobs:
payload = {
"iat": int(time.time()),
"exp": int(time.time()) + 600, # 10-minute expiration
"iss": $APP_ID
"iss": $GH_APP_ID
}
print(jwt.encode(payload, private_key, algorithm="RS256"))
EOF
Expand All @@ -99,7 +97,7 @@ jobs:
# Request Installation Access Token
ACCESS_TOKEN=$(curl -s -X POST -H "Authorization: Bearer $JWT" \
-H "Accept: application/vnd.github.v3+json" \
https://api.github.com/app/installations/$INSTALLATION_ID/access_tokens | jq -r '.token')
"https://api.github.com/app/installations/$INSTALLATION_ID/access_tokens" | jq -r '.token')

echo "ACCESS_TOKEN=$ACCESS_TOKEN" >> "$GITHUB_ENV"

Expand Down Expand Up @@ -165,7 +163,7 @@ jobs:
run: |
diff_output=$(git diff)
if [ -n "$diff_output" ]; then
echo "uncommitted_changes=$(echo $diff_output)" >> "$GITHUB_OUTPUT"
echo "uncommitted_changes=$diff_output" >> "$GITHUB_OUTPUT"
fi

- name: Stage changes
Expand Down