Open
Conversation
added 2 commits
November 18, 2022 17:02
Removes some hard-coded paths that prevented compiling locally, or when cloned into a monorepo
This seemed to be breaking things in our monorepo. Not sure why, but it doesn't seem to break non-monorepo builds
|
Nice fix @reccanti! This helped me a lot when trying to build the plugin locally. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
When I tried cloning and building this locally in a monorepo, I noticed that some of the hard-coded paths were breaking. Hoping this will fix some things so that running
yarn buildandyarn build:watchwill work with a fresh clone.I think some of the things here might be universally helpful:
buildandbuild:watchscripts, or"typeRoots"paths to"types"listings).Others might be more specific to my use-case:
"allowSyntheticDefaultExports"needed to be added to get this working in our local monorepo, but didn't seem to be needed for a standalone clone. Adding it didn't seem to break the standalone clone build, though.Anyway, happy to make any edits or take suggestions on this!