Expose multiline parameter in ClassSignature#9084
Open
FilippoVigani wants to merge 2 commits intodetekt:mainfrom
Open
Expose multiline parameter in ClassSignature#9084FilippoVigani wants to merge 2 commits intodetekt:mainfrom
ClassSignature#9084FilippoVigani wants to merge 2 commits intodetekt:mainfrom
Conversation
Collaborator
cortinico
reviewed
Mar 4, 2026
| ClassSignature: | ||
| active: true | ||
| autoCorrect: true | ||
| forceMultilineWhenParameterCountGreaterOrEqualThan: 'unset' |
Member
There was a problem hiding this comment.
This is really long. Could we shorten it a bit? forceMultilineWhenParamCount or multilineWhenParamThreshold
Author
There was a problem hiding this comment.
Arguably it could be improved yeah.
I wrote it this way to maintain consistency with FunctionSignature's parameter.
In this case would you favor readability over being consistent albeit overly verbose? On the one hand it's very long, on the other it's consistent with ktlint parameters, like the ones introduced in #5256.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #9083.