This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fixing order of type checking and value reassignment #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleah
commented
Dec 1, 2017
| node_modules | ||
| npm-debug.log | ||
| .DS_Store | ||
| lib |
Author
There was a problem hiding this comment.
Removed the lib from gitignore. There are build issues when trying to pull this into the FE repo . The lib isn't being properly built when being included in the FE, so including the lib here is a quick fix for this issue.
mleah
commented
Dec 1, 2017
| @@ -1,3 +1,5 @@ | |||
| // @noflow | |||
Author
There was a problem hiding this comment.
Flow tests for this file were failing, even on master of the fork 😕
This addition stops flow (a typing library) from trying to type this library.
mleah
commented
Dec 1, 2017
| val = val[val.length === 2 ? 1 : 0]; | ||
| } | ||
|
|
||
| const type = getType(val); |
Author
There was a problem hiding this comment.
This is the change needed to (hopefully) fully fix the issue with the FE.
SlaunchaMan
approved these changes
Dec 1, 2017
|
Not throwing any errors in the console and everything is working as expected. LGTM! |
This was referenced Dec 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR to fix an issue we are seeing on the MetricsOne frontend.
This issue is currently up in a PR to be fixed on the
redux-devtools-inspectorrepo. However, it has been up since May, and there is no resolution in sight.There is also an issue up for the original repo.
Testing Steps
In order to test this, you will need to pull this branch on
redux-devtools-inspectorinto your FE.yarn remove redux-devtools-inspector.yarn add github:detroit-labs/redux-devtools-inspector#LNG-2305-Fixing-typechecking-order-issueOnce this PR is approved and merged in, I will put up a corresponding FE PR.