-
Notifications
You must be signed in to change notification settings - Fork 4
feat: schedule 2025 #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: schedule 2025 #723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @anyulled, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello! Gemini here, providing a summary of this pull request. The primary goal of this PR, based on the title and changes, is to integrate the 2025 event schedule into the website. This is achieved by adding the Sessionize embed script to the main HTML file, enabling the schedule link in the navigation, and updating the Sessionize API endpoint used to fetch the schedule data.
Highlights
- Enable Schedule Navigation: The 'SCHEDULE' link in the 2025 navigation data (
src/components/Navigation/NavigationData.ts) has been uncommented, making the schedule page accessible from the main navigation. - Update Sessionize API Endpoint: The Sessionize API endpoint used to fetch the schedule data in
src/views/Schedule/Schedule.tsxhas been updated, changing the event ID fromw8mdb9k5tokdiixcgx. This points the schedule component to the correct 2025 event data.
Changelog
- index.html
- Added Sessionize embed script before the closing
</body>tag (lines 189-459).
- Added Sessionize embed script before the closing
- src/components/Navigation/NavigationData.ts
- Imported
ROUTE_SCHEDULE(line 7). - Uncommented the 'SCHEDULE' navigation item for 2025 (line 24).
- Imported
- src/views/Schedule/Schedule.tsx
- Updated import paths from relative to absolute using
@/alias (lines 1-9). - Changed the Sessionize API endpoint URL to use the 2025 event ID
kdiixcgx(line 24).
- Updated import paths from relative to absolute using
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
New schedule arrives,
Sessions listed, times are set,
Plan your conference.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the schedule for the 2025 event. The changes involve updating navigation data, creating a new Schedule component, and embedding Sessionize script into the index.html. The core functionality of adding the schedule seems to be in place, but there are a few significant issues related to correctness and security that need to be addressed.
Summary of Findings
- Incorrect data source for 2025 schedule: The Schedule component for 2025 is currently importing data from
2024.json, leading to incorrect information being displayed. - Incorrect
getElementByIdusage: ThegetElementByIdcall includes the#prefix, which will prevent it from finding the target element. - Potential XSS vulnerability via
innerHTML: Injecting fetched HTML directly usinginnerHTMLposes a security risk if the external source is compromised. It also interferes with React's rendering. - Sessionize API endpoint ID: Verify that the Sessionize API ID used in the fetch call is correct for the 2025 schedule.
- Embedded Sessionize script in HTML: Embedding the large, minified Sessionize script directly in
index.htmlimpacts readability and maintainability compared to external script inclusion (Severity: low - not commented per settings).
Merge Readiness
This pull request introduces the 2025 schedule functionality. However, there are several high-severity issues related to correctness (using 2024 data, incorrect DOM manipulation) and security (potential XSS via innerHTML) that must be addressed before merging. I am unable to approve this pull request. Please address the identified issues and request another review.
✅ Deploy Preview for dev-bcn ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
@gemini review |
|
Thanks for submitting this pull request to update the schedule for 2025! I've reviewed the changes. The PR correctly updates the navigation, the 2025 data file, and the Schedule component to point to the new Sessionize data. However, I've identified a couple of areas that need attention before merging:
-</script> \ No newline at end of file ```
Given the high severity issues, I am requesting changes before this PR can be merged. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces the schedule for the 2025 conference, enabling the display of the schedule on the website. The changes involve enabling the schedule in the data file, adding the schedule route to the navigation, and integrating the Sessionize schedule into the Schedule component. Overall, the changes seem well-structured and logical. However, there are a few areas that could be improved, particularly in terms of code clarity and maintainability.
Summary of Findings
- Incorrect ID selector: The
idattribute inSchedule.tsxshould bescheduleinstead of#schedule. - Sessionize ID Hardcoding: The sessionize ID is hardcoded in
Schedule.tsx. Consider externalizing it to the2025.jsonfile. - Inconsistent Path Aliases: Path aliases are used inconsistently in
Schedule.tsx. Consider using them consistently throughout the project.
Merge Readiness
The pull request introduces the schedule feature for the 2025 conference. While the changes are functional, there are a few improvements that can be made to enhance code quality and maintainability. Specifically, the incorrect ID selector and hardcoded Sessionize ID should be addressed before merging. I am unable to approve this pull request, and recommend that others review and approve this code before merging.





No description provided.