Skip to content

fix: update codely link #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anyulled merged 1 commit into from
Jun 19, 2025
Merged

fix: update codely link #737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/views/Home/components/Sponsors/SponsorsData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export const sponsors: Sponsors = {
{
name: "Codely",
image: "images/sponsors/codely.png",
website: "https://codely.com/pro/jbcnconf22",
website: "https://codely.com/",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The update to a more general Codely URL (https://codely.com/) is a good improvement, as the previous link (https://codely.com/pro/jbcnconf22) appeared to be event-specific (likely for JBCNConf 2022) and potentially outdated for the current/upcoming event context.

For consistency and to ensure a good user experience on historical pages, please consider if this same outdated link, which also exists in src/2023/Home/components/Sponsors/SponsorsData.ts (line 210), should also be updated to the general URL.

  • If past event pages (like the 2023 edition) are intended to have functional and current sponsor links, updating it there would be beneficial.
  • If, however, historical data is meant to be an exact snapshot of what was displayed at that time, including potentially outdated links, then leaving it as is might be intentional.

Clarifying the policy for links on historical pages or ensuring consistency would be helpful.

},
],
supporters: [],
Expand Down
Loading