Merge release candidate code #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass the config - Fix `Xtz.StronglyTyped.Benchmark.Models.IntStructId.IsValid()`
- Add support for collection generation
- Fix `.ThrowIfInvalid()` for struct when inner type is `string` - Add custom `.ToString()` for `DateTime` and `TimeSpan` - Minor refactoring
- Add tests for structs with all supported inner types
- Extract `StronglyTypedNewtonsoftConverter` to a separate NuGet package - Implement custom tricky conversions when reader reads value of a type different from a target type - `long` -> `ushort` - `long` -> `int` - `long` -> `decimal` - `double` -> `decimal` - `double` -> `float` - `BigInteger` -> `decimal` - `BigInteger` -> `ushort` (not sure if it's the case) - `BigInteger` -> `int` (not sure if it's the case) - `BigInteger` -> `long` (not sure if it's the case) - Implement custom TimeSpan parsing from ISO-8601 format using `XmlConvert` - Implement custom serialization for numbers - Implement custom serialization for `bool`
- Use `JsonSerializerSettings` with `StronglyTypedNewtonsoftConverter` provided - Add another strongly-typed property which is never set for tests with `null`
- Add strongly-typed models with all supported inner types - Add `BoolTests` - Add `SystemTextJsonTests` to test JSON serialization based on `System.Text.Json`
- Add tests for JSON serialization with `Newtonsoft.Json` based on `StronglyTypedNewtonsoftConverter` - Add tests for JSON deserialization with `Newtonsoft.Json` based on `StronglyTypedNewtonsoftConverter`
- Fix tests (many are failing now) - Uncomment accidentially commented out tests
- Fix `StronglyTypedNewtonsoftConverter` (`Newtonsoft.Json` converter) - Fix `StronglyTypedJsonConverter<TStronglyTyped>` (`System.Text.Json` converter) - Fix tests
…e `[GeneratedCode]`
…s or explicitly suppressing them
- Add usings - Remove redundant namespaces usage - Split `IEquatable.Equals()` implementation into two (struct, class) - Handle `nullable`
…Typed.BuiltinTypes`
- Replace customly-implemented types by `[StrongType(...)]` - Drop `IConvertible` support
- Add `Microsoft.CodeAnalysis.BannedApiAnalyzers` - Add `Microsoft.CodeAnalysis.CSharp.CodeStyle` - Add `Microsoft.CodeAnalysis.NetAnalyzers` - Add `Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers` - Add `Roslynator.Analyzers` - Add `Roslynator.CodeAnalysis.Analyzers`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.