Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-clocks-love.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@devup-ui/react": patch
---

Change default generic type of VStack
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@
"benchmark": "node benchmark.js"
},
"devDependencies": {
"eslint-plugin-devup": "^2.0.1",
"eslint-plugin-devup": "^2.0.3",
"eslint": "^9.20.1",
"vitest": "^3.0.5",
"@vitest/coverage-v8": "^3.0.5",
"@changesets/cli": "^2.27.12",
"@types/node": "^22.13.1",
"@changesets/cli": "^2.28.0",
"@types/node": "^22.13.4",
"happy-dom": "^17.1.0",
"@testing-library/react": "^16.2.0"
},
"author": "devfive",
"packageManager": "pnpm@10.3.0",
"packageManager": "pnpm@10.4.1",
"resolutions": {
"vite": "^6"
}
Expand Down
3 changes: 1 addition & 2 deletions packages/react/src/components/ThemeScript.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ export function ThemeScript({ auto = true, theme }: ThemeScriptProps) {
dangerouslySetInnerHTML={{
__html: theme
? `(function (){document.documentElement.setAttribute('data-theme',${theme});}())`
: `(function (){
const o=localStorage.getItem('__DF_THEME_SELECTED__')||(${String(auto)}&&window.matchMedia('(prefers-color-scheme:dark)').matches?'dark':'default');document.documentElement.setAttribute('data-theme',o);})()`,
: `(function (){const o=localStorage.getItem('__DF_THEME_SELECTED__')||(${String(auto)}&&window.matchMedia('(prefers-color-scheme:dark)').matches?'dark':'default');document.documentElement.setAttribute('data-theme',o);})()`,
}}
/>
)
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/VStack.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { DevupProps } from '../types/props'
import type { Merge } from '../types/utils'

export function VStack<T extends React.ElementType = 'span'>(
export function VStack<T extends React.ElementType = 'div'>(
// eslint-disable-next-line @typescript-eslint/no-unused-vars
props: Merge<React.ComponentProps<T>, DevupProps<T>>,
): React.ReactElement {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,15 @@
exports[`ThemeScript > should apply ThemeScript 1`] = `
<div>
<script>
(function (){
const o=localStorage.getItem('__DF_THEME_SELECTED__')||(true&&window.matchMedia('(prefers-color-scheme:dark)').matches?'dark':'default');document.documentElement.setAttribute('data-theme',o);})()
(function (){const o=localStorage.getItem('__DF_THEME_SELECTED__')||(true&&window.matchMedia('(prefers-color-scheme:dark)').matches?'dark':'default');document.documentElement.setAttribute('data-theme',o);})()
</script>
</div>
`;

exports[`ThemeScript > should apply ThemeScript with not auto 1`] = `
<div>
<script>
(function (){
const o=localStorage.getItem('__DF_THEME_SELECTED__')||(false&&window.matchMedia('(prefers-color-scheme:dark)').matches?'dark':'default');document.documentElement.setAttribute('data-theme',o);})()
(function (){const o=localStorage.getItem('__DF_THEME_SELECTED__')||(false&&window.matchMedia('(prefers-color-scheme:dark)').matches?'dark':'default');document.documentElement.setAttribute('data-theme',o);})()
</script>
</div>
`;
Expand Down
Loading
Loading