Skip to content

Fix x position logic in SelectContainer #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
belltalion merged 7 commits into from
Sep 8, 2025
+8 −4
Merged

Fix x position logic in SelectContainer #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a55baba
Fix x position logic in SelectContainer
forestream Sep 8, 2025
a3179a6
Fix min left
forestream Sep 8, 2025
91f3abe
Refactor
forestream Sep 8, 2025
0e45425
Update snapshot
forestream Sep 8, 2025
39d4e4b
Run changeset
forestream Sep 8, 2025
39d545e
Rerun action
forestream Sep 8, 2025
7b9383e
Remove brackets
forestream Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thick-ways-happen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@devup-ui/components": patch
---

Fix Select overflow position
2 changes: 1 addition & 1 deletion ...ages/components/src/components/Select/__tests__/__snapshots__/index.browser.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ exports[`Select > should render with overflow screen 1`] = `
<div
aria-label="Select container"
class="display-0-flex--0 flex-direction-0-column--0 background-0-var(--inputBg,light-dark(#FFF,#2E2E2E))--1 border-0-1px solid var(--border,light-dark(#E4E4E4,#434343))--1 border-radius-0-8px--1 bottom-0--4px--1 box-shadow-0-0 2px 2px 0 var(--base10,light-dark(#0000001A,#FFFFFF1A))--1 height-0-fit-content--1 width-0-fit-content--1 gap-0-6px--1 min-width-0-232px--1 padding-0-10px--1 position-0-fixed--1 user-select-0-none--1 z-index-0-1--1 "
style="top: 10px; left: -1100px; bottom: 778px;"
style="top: 10px; left: 0px; bottom: 778px;"
>
<div
class="display-0-flex--0 align-items-0-center--1 border-radius-0-6px--1 height-0-40px--1 padding-right-0-10px--1 padding-left-0-10px--1 transition-0-background-color .1s ease-in-out--1 color-0-var(--selectDisabled,light-dark(#C4C5D1,#45464D))--1 cursor-0-default--1 font-weight-0-400--1 gap-0-0--1 "
Expand Down
5 changes: 2 additions & 3 deletions packages/components/src/components/Select/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ export function SelectContainer({
// 요소가 움직일 때마다(스크롤, 리사이즈 등) 위치를 갱신하도록 이벤트를 등록합니다.
const updatePosition = () => {
const {
width,
height,
x: comboboxX,
y: comboboxY,
Expand All @@ -241,15 +240,15 @@ export function SelectContainer({
document.documentElement.scrollHeight

const isOverflowRight =
el.offsetWidth + left + window.scrollX + width + x >
el.offsetWidth + left + window.scrollX + x >
document.documentElement.scrollWidth

if (isOverflowBottom)
el.style.bottom = `${window.innerHeight - comboboxY + 10}px`
else el.style.top = `${comboboxY + height + 10 + y}px`

if (isOverflowRight)
el.style.left = `${comboboxX - el.offsetWidth + combobox.offsetWidth + x}px`
el.style.left = `${Math.max(comboboxX - el.offsetWidth + combobox.offsetWidth, 0) + x}px`
else el.style.left = `${comboboxX + x}px`
}

Expand Down