HTTP response bodyとmultipart.WriterのClose処理追加#226
Closed
massongit wants to merge 7 commits intoupdate_super_linter_3from
Closed
HTTP response bodyとmultipart.WriterのClose処理追加#226massongit wants to merge 7 commits intoupdate_super_linter_3from
massongit wants to merge 7 commits intoupdate_super_linter_3from
Conversation
- エラーシャドーイングを修正（closeErr変数を使用） - ParseLocationWithClient関数の循環的複雑度を削減（関数分割） - gocycloとgovetのlintエラーを解消 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- executeAndReadResponse関数を追加して重複コードを集約 - geocodePlace関数とmakeHTTPRequest関数で共通化 - コード重複率を0.37%から0%に削減 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
リソースリークを防ぐため、HTTP response bodyとmultipart.WriterのClose処理を追加します。
また、複雑になっていた
ParseLocationWithClientの処理を分割し、共通処理を関数に切り出します。#224 を前提としています。