Skip to content

テストコードでearly returnパターンを使用してifのネストを減らす #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
massongit merged 2 commits into from
Feb 14, 2026
+26 −21
Merged

テストコードでearly returnパターンを使用してifのネストを減らす #272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eddfefc
テストコードでearly returnパターンを使用してifのネストを減らす
massongit Jan 29, 2026
4ccb758
Merge branch 'main' into fix_test
massongit Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 26 additions & 21 deletions lib/amesh/amesh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,12 +272,15 @@ func TestCreateAmeshImage(t *testing.T) {
return
}

if tt.checkCenterColor {
centerColor := result.RGBAAt(bounds.Dx()/2, bounds.Dy()/2)
if centerColor.R != 255 || centerColor.G != 255 || centerColor.B != 255 || centerColor.A != 255 {
t.Errorf("Expected white center pixel but got R=%d, G=%d, B=%d, A=%d",
centerColor.R, centerColor.G, centerColor.B, centerColor.A)
}
if !tt.checkCenterColor {
return
}

centerColor := result.RGBAAt(bounds.Dx()/2, bounds.Dy()/2)

if centerColor.R != 255 || centerColor.G != 255 || centerColor.B != 255 || centerColor.A != 255 {
t.Errorf("Expected white center pixel but got R=%d, G=%d, B=%d, A=%d",
centerColor.R, centerColor.G, centerColor.B, centerColor.A)
}
})
}
Expand Down Expand Up @@ -363,23 +366,25 @@ func TestCreateImageReaderWithClient(t *testing.T) {
return
}

if tt.expectError == nil {
if result == nil {
t.Error("CreateImageReaderWithClient() returned nil reader")
return
}
if tt.expectError != nil {
return
}

// io.Readerからデータを読み取って、有効なPNGデータかチェック
data, err := io.ReadAll(result)
if err != nil {
t.Error(err)
return
}
if result == nil {
t.Error("CreateImageReaderWithClient() returned nil reader")
return
}

// PNGデータのデコードを試行
if _, _, err = image.Decode(bytes.NewReader(data)); err != nil {
t.Error(err)
}
// io.Readerからデータを読み取って、有効なPNGデータかチェック
data, err := io.ReadAll(result)
if err != nil {
t.Error(err)
return
}

// PNGデータのデコードを試行
if _, _, err = image.Decode(bytes.NewReader(data)); err != nil {
t.Error(err)
}
})
}
Expand Down