fix: correct standard error pipe logic in Cilium command execution

devantler · devantler · commit 5c405b8c500d · 2025-03-12T23:38:43.000+01:00
Signed-off-by: Nikolai Emil Damm &lt;nikolaiemildamm@icloud.com&gt;
diff --git a/src/Devantler.CiliumCLI/Cilium.cs b/src/Devantler.CiliumCLI/Cilium.cs
@@ -67,7 +67,7 @@ internal static Command GetCommand(PlatformID? platformID = default, Architectur
       .WithValidation(validation)
       .WithStandardInputPipe(PipeSource.FromStream(stdInConsole))
       .WithStandardOutputPipe(silent ? PipeTarget.ToStringBuilder(stdOutBuffer) : PipeTarget.Merge(PipeTarget.ToStringBuilder(stdOutBuffer), PipeTarget.ToStream(stdOutConsole)))
-      .WithStandardErrorPipe(silent || !includeStdErr ? PipeTarget.ToStringBuilder(stdErrBuffer) : PipeTarget.Merge(PipeTarget.ToStringBuilder(stdErrBuffer), PipeTarget.ToStream(stdErrConsole)));
+      .WithStandardErrorPipe(silent && !includeStdErr ? PipeTarget.ToStringBuilder(stdErrBuffer) : PipeTarget.Merge(PipeTarget.ToStringBuilder(stdErrBuffer), PipeTarget.ToStream(stdErrConsole)));
     var result = await command.ExecuteAsync(cancellationToken);
     return (result.ExitCode, stdOutBuffer.ToString() + stdErrBuffer.ToString());
   }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ internal static Command GetCommand(PlatformID? platformID = default, Architectur`
`67`	`67`	`.WithValidation(validation)`
`68`	`68`	`.WithStandardInputPipe(PipeSource.FromStream(stdInConsole))`
`69`	`69`	`.WithStandardOutputPipe(silent ? PipeTarget.ToStringBuilder(stdOutBuffer) : PipeTarget.Merge(PipeTarget.ToStringBuilder(stdOutBuffer), PipeTarget.ToStream(stdOutConsole)))`
`70`		`- .WithStandardErrorPipe(silent \|\| !includeStdErr ? PipeTarget.ToStringBuilder(stdErrBuffer) : PipeTarget.Merge(PipeTarget.ToStringBuilder(stdErrBuffer), PipeTarget.ToStream(stdErrConsole)));`
	`70`	`+ .WithStandardErrorPipe(silent && !includeStdErr ? PipeTarget.ToStringBuilder(stdErrBuffer) : PipeTarget.Merge(PipeTarget.ToStringBuilder(stdErrBuffer), PipeTarget.ToStream(stdErrConsole)));`
`71`	`71`	`var result = await command.ExecuteAsync(cancellationToken);`
`72`	`72`	`return (result.ExitCode, stdOutBuffer.ToString() + stdErrBuffer.ToString());`
`73`	`73`	`}`