Skip to content

Conversation

@williamoconnorme
Copy link
Contributor

Closes #1266

@williamoconnorme williamoconnorme requested a review from a team as a code owner February 7, 2025 15:18
bamurtaugh
bamurtaugh previously approved these changes Feb 26, 2025
Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this!

@williamoconnorme
Copy link
Contributor Author

@bamurtaugh thanks, I've pushed one more commit to update the README for this devcontainer and merged in the latest from the main branch which has reset the PR reviews. Would you mind reviewing this once more

@eljog eljog merged commit 13521bc into devcontainers:main Feb 27, 2025
12 checks passed
@williamoconnorme williamoconnorme deleted the feature/remove-azure-terraform-extension branch February 27, 2025 09:01
@delilahw
Copy link

delilahw commented Mar 7, 2025

Hey all, thanks for working on this PR!

I noticed that the feature version v1.3.8 was not bumped. Is this intentional? A similar PR, Remove rebornix.Ruby extension (#737), included a version bump.

This can cause problems for teams who use caching in their devcontainer image builds; the tooling won't know that there was a change to this feature because the version number remained the same.

@williamoconnorme
Copy link
Contributor Author

@delilahw You're correct, the version bump was missed in this PR. I've opened #1290 to address this

@delilahw
Copy link

delilahw commented Mar 7, 2025

Awesome, thanks @williamoconnorme!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform devcontainer: ms-azuretools.vscode-azureterraform is deprecated

5 participants