Skip to content

Conversation

@Kaniska244
Copy link
Contributor

Ref# #1270

Description: Unable to fetch the latest libcudnn9 library version for cuda 12.3 or greater versions.

Root Cause: The regular expression used for fetching latest libcudnn9 library version was incorrect as it wasn't expecting digit 1 to be present in the version number.

Changelog: Changes done in install.sh script of nvidia-cuda to correct the regular expression & also changes done in the test scripts to test the presence of latest libcudnn9 library instead of specific version when the libcudnn version isn't specified.

Checklist:

  • Checked that applied changes work as expected.

@Kaniska244 Kaniska244 marked this pull request as ready for review February 14, 2025 10:20
@Kaniska244 Kaniska244 requested a review from a team as a code owner February 14, 2025 10:20
@Mathiyarasy Mathiyarasy requested a review from ddoyle2017 March 3, 2025 16:49
Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed in stand-up, this approach makes sense! LGTM⚡

@ddoyle2017 ddoyle2017 merged commit 8f42e09 into devcontainers:main Mar 3, 2025
12 checks passed
@Kaniska244 Kaniska244 deleted the Issue_check_common-utis2 branch March 4, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants