[docker-in-docker] - Correction in fetching previous version from github api url #1302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Name
Description of Changes
Correcting the fallback method for Docker-in-Docker Feature as previously it was fetching the latest version to fetch the previous version from the GitHub API URL. This was misleading and therefore now fetching the second element's tag_name property's value in releases array json for correcting the above
Docker-in-docker dockerDashComposeVersion is confusing. As per Issue dockerDashComposeVersion should default to latest i.e.)v2
But current implementation shows latest and v2 as two different options
Changed the default to v2 as similar to docker-outside-of-docker issue
-When we use v2 code is implemented to fetch the latest tag from docker compose
If latest tag is created but code is not released will fallback to the previous release tag
If latest is used instead of v2 still the latest tag is fetched from v2 version so there shouldnt be any change in functionality
Changelog
Checklist