Skip to content

Conversation

@Mathiyarasy
Copy link
Contributor

@Mathiyarasy Mathiyarasy commented Mar 19, 2025

Feature Name

  • Docker-In-Docker

Description of Changes

  • Correcting the fallback method for Docker-in-Docker Feature as previously it was fetching the latest version to fetch the previous version from the GitHub API URL. This was misleading and therefore now fetching the second element's tag_name property's value in releases array json for correcting the above

  • Docker-in-docker dockerDashComposeVersion is confusing. As per Issue dockerDashComposeVersion should default to latest i.e.)v2
    But current implementation shows latest and v2 as two different options

  • Changed the default to v2 as similar to docker-outside-of-docker issue
    -When we use v2 code is implemented to fetch the latest tag from docker compose

  • If latest tag is created but code is not released will fallback to the previous release tag

  • If latest is used instead of v2 still the latest tag is fetched from v2 version so there shouldnt be any change in functionality

Changelog

  • Made changes to install.sh file
  • Made changes to docker_build_compose_fallback.sh file in test case scenarios implementations of docker-outside-of-docker
  • Changed the dockerDashComposeVersion default value to v2 instead of latest in devcontainer.features.json

Checklist

  • Checked that applied changes work as expected

@Mathiyarasy Mathiyarasy reopened this Mar 19, 2025
@Mathiyarasy Mathiyarasy reopened this Mar 24, 2025
@Mathiyarasy Mathiyarasy reopened this Mar 25, 2025
@Mathiyarasy Mathiyarasy marked this pull request as ready for review March 25, 2025 08:53
@Mathiyarasy Mathiyarasy requested a review from a team as a code owner March 25, 2025 08:53
@Kaniska244 Kaniska244 self-requested a review March 25, 2025 12:02
Copy link
Contributor

@Kaniska244 Kaniska244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine.

@ddoyle2017 ddoyle2017 merged commit 87fd9a3 into devcontainers:main Mar 26, 2025
332 of 334 checks passed
@Mathiyarasy Mathiyarasy deleted the dev/Mathi/DockerComposeInstalationIssue branch May 22, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants