Skip to content

[github-cli] - Fix excessive wget download output in GitHub CLI feature #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlvaroRausell merged 4 commits into from
Sep 16, 2025
Merged

[github-cli] - Fix excessive wget download output in GitHub CLI feature #1478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2504e9a
Initial plan
Copilot Sep 11, 2025
a7a750d
Fix excessive wget download output in GitHub CLI feature
Copilot Sep 11, 2025
af76e2e
Merge pull request #2 from Kaniska244/copilot/fix-8763e86d-4565-4e4f-…
Kaniska244 Sep 11, 2025
32b0e4a
Version bump.
Kaniska244 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/github-cli/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "github-cli",
"version": "1.0.14",
"version": "1.0.15",
"name": "GitHub CLI",
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/github-cli",
"description": "Installs the GitHub CLI. Auto-detects latest version and installs needed dependencies.",
Expand Down
4 changes: 2 additions & 2 deletions src/github-cli/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,14 +195,14 @@ install_deb_using_github() {

mkdir -p /tmp/ghcli
pushd /tmp/ghcli
wget https://github.com/cli/cli/releases/download/v${CLI_VERSION}/${cli_filename}
wget -q --show-progress --progress=dot:giga https://github.com/cli/cli/releases/download/v${CLI_VERSION}/${cli_filename}
exit_code=$?
set -e
if [ "$exit_code" != "0" ]; then
# Handle situation where git tags are ahead of what was is available to actually download
echo "(!) github-cli version ${CLI_VERSION} failed to download. Attempting to fall back one version to retry..."
find_prev_version_from_git_tags CLI_VERSION https://github.com/cli/cli
wget https://github.com/cli/cli/releases/download/v${CLI_VERSION}/${cli_filename}
wget -q --show-progress --progress=dot:giga https://github.com/cli/cli/releases/download/v${CLI_VERSION}/${cli_filename}
fi

dpkg -i /tmp/ghcli/${cli_filename}
Expand Down